Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump FC for 4.0.0 release #2041

Closed
1 of 17 tasks
abitmore opened this issue Nov 3, 2019 · 2 comments
Closed
1 of 17 tasks

Bump FC for 4.0.0 release #2041

abitmore opened this issue Nov 3, 2019 · 2 comments
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design
Milestone
4.0.0 - Protocol ...

Comments

@abitmore
Copy link
Member

abitmore commented Nov 3, 2019

Bug Description
It seems at least bitshares/bitshares-fc#165 for #1996 is not included in release branch, likely due to a poorly resolved conflict when merging.

Impacts
Describe which portion(s) of BitShares Core may be impacted by this bug. Please tick at least one box.

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

CORE TEAM TASK LIST

  • Evaluate / Prioritize Bug Report
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@abitmore abitmore added the 3d Bug Classification indicating the existing implementation does not match the intention of the design label Nov 3, 2019
@pmconrad
Copy link
Contributor

pmconrad commented Nov 4, 2019

Good catch, thanks!

@pmconrad pmconrad mentioned this issue Nov 4, 2019
Merged
@abitmore
Copy link
Member Author

abitmore commented Nov 4, 2019

Fixed by #2042.

@abitmore abitmore closed this as completed Nov 4, 2019
@abitmore abitmore mentioned this issue Jun 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design
Projects
None yet
Milestone
4.0.0 - Protocol Upgrade Release
Development

No branches or pull requests
2 participants
@pmconrad @abitmore