assigned value is garbage

[fbthrift]

/libraries/fc/src/compress/smaz.cpp line 150:

flush[1] = verb[0]; //verb[0] is not initialization

in line 88:char verb[256], *_out = out; // verb[256] is defined here but not initialization

and in line 125: goto out: but verb[256] is also not initialization

[abitmore]

Thanks for the report.

I think this is not being used in core, so perhaps we can simply remove it.

[pmconrad]

I believe the report is wrong. When line 125 is hit, we either have verblen == 0 AND flush == NULL, or verblen > 0 AND flush != NULL (from assignment in line 114). verblen > 0 can only happen if line 133 has been hit at least once, which implies that verb[0] has been initialized in line 132. OTOH, if verblen == 0 then flush == NULL, which means line 150 will not be hit.

Nevertheless, the code looks rather dirty and is in fact not used in the core. I think removing it would be OK.

[pmconrad]

Resolved via bitshares/bitshares-fc#51

[abitmore]

Just a note: still need to bump FC.

[pmconrad]

not really - can wait until next bump