[PM-27727] Update WASM-bindgen (#540)

## 🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27727

## 📔 Objective

Update WASM-bindgen and removed `VectorIntoJsValue` implementations, as
those types aren't needed anymore and were removed from wasm-bindgen.

The TS typings now include `[Symbol.dispose](): void;` for the Client
classes, so I've updated the TS check script to include the
`esnext.disposable` feature, which we're already using in the clients
repo anyway.

Prerequisite for #330 

## ⏰ Reminders before review

- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or
informed the documentation
  team

## 🦮 Reviewer guidelines

<!-- Suggested interactions but feel free to use (or not) as you desire!
-->

- 👍 (`:+1:`) or similar for great changes
- 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info
- ❓ (`:question:`) for questions
- 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry
that's not quite a confirmed
  issue and could potentially benefit from discussion
- 🎨 (`:art:`) for suggestions / improvements
- ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or
concerns needing attention
- 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or
indications of technical debt
- ⛏ (`:pick:`) for minor or nitpick changes

Author: dani-garcia

.github/workflows/build-wasm-internal.yml

@@ -90,7 +90,7 @@ jobs:
           key: wasm-cargo-cache
 
       - name: Install wasm-bindgen-cli
-        run: cargo install wasm-bindgen-cli --version 0.2.100 --locked
+        run: cargo install wasm-bindgen-cli --version 0.2.105 --locked
 
       - name: Build
         run: ./build.sh -r ${{ matrix.license_type.build_flags }}

.github/workflows/rust-test.yml

@@ -74,7 +74,7 @@ jobs:
         uses: Swatinem/rust-cache@f0deed1e0edfc6a9be95417288c0e1099b1eeec3 # v2.7.7
 
       - name: Install wasm-bindgen-cli
-        run: cargo install wasm-bindgen-cli --version 0.2.100 --locked
+        run: cargo install wasm-bindgen-cli --version 0.2.105 --locked
 
       - name: Test WASM
         run: cargo test --target wasm32-unknown-unknown -p bitwarden-wasm-internal -p bitwarden-threading -p bitwarden-error -p bitwarden-uuid --all-features

Cargo.lock

@@ -82,9 +82,9 @@ tsify = { version = ">=0.5.5, <0.6", features = [
 uniffi = "=0.29.4"
 uuid = { version = ">=1.3.3, <2.0", features = ["serde", "v4", "js"] }
 validator = { version = ">=0.18.1, <0.21", features = ["derive"] }
-wasm-bindgen = { version = ">=0.2.91, <0.3", features = ["serde-serialize"] }
-wasm-bindgen-futures = "0.4.41"
-wasm-bindgen-test = "0.3.45"
+wasm-bindgen = { version = ">=0.2.105, <0.3", features = ["serde-serialize"] }
+wasm-bindgen-futures = "0.4.55"
+wasm-bindgen-test = "0.3.55"
 wiremock = ">=0.6.0, <0.7"
 zxcvbn = ">=3.0.1, <4.0"
 

Cargo.toml

@@ -886,24 +886,6 @@ impl Decryptable<KeyIds, SymmetricKeyId, CipherListView> for Cipher {
     }
 }
 
-#[cfg(feature = "wasm")]
-impl wasm_bindgen::__rt::VectorIntoJsValue for Cipher {
-    fn vector_into_jsvalue(
-        vector: wasm_bindgen::__rt::std::boxed::Box<[Self]>,
-    ) -> wasm_bindgen::JsValue {
-        wasm_bindgen::__rt::js_value_vector_into_jsvalue(vector)
-    }
-}
-
-#[cfg(feature = "wasm")]
-impl wasm_bindgen::__rt::VectorIntoJsValue for CipherView {
-    fn vector_into_jsvalue(
-        vector: wasm_bindgen::__rt::std::boxed::Box<[Self]>,
-    ) -> wasm_bindgen::JsValue {
-        wasm_bindgen::__rt::js_value_vector_into_jsvalue(vector)
-    }
-}
-
 impl IdentifyKey<SymmetricKeyId> for Cipher {
     fn key_identifier(&self) -> SymmetricKeyId {
         match self.organization_id {

crates/bitwarden-vault/src/cipher/cipher.rs

@@ -96,12 +96,3 @@ pub struct CipherRiskResult {
     /// None if not found or if no password_map was provided.
     pub reuse_count: Option<u32>,
 }
-
-#[cfg(feature = "wasm")]
-impl wasm_bindgen::__rt::VectorIntoJsValue for CipherRiskResult {
-    fn vector_into_jsvalue(
-        vector: wasm_bindgen::__rt::std::boxed::Box<[Self]>,
-    ) -> wasm_bindgen::JsValue {
-        wasm_bindgen::__rt::js_value_vector_into_jsvalue(vector)
-    }
-}

crates/bitwarden-vault/src/cipher_risk/types.rs

@@ -41,15 +41,6 @@ pub struct FolderView {
     pub revision_date: DateTime<Utc>,
 }
 
-#[cfg(feature = "wasm")]
-impl wasm_bindgen::__rt::VectorIntoJsValue for FolderView {
-    fn vector_into_jsvalue(
-        vector: wasm_bindgen::__rt::std::boxed::Box<[Self]>,
-    ) -> wasm_bindgen::JsValue {
-        wasm_bindgen::__rt::js_value_vector_into_jsvalue(vector)
-    }
-}
-
 impl IdentifyKey<SymmetricKeyId> for Folder {
     fn key_identifier(&self) -> SymmetricKeyId {
         SymmetricKeyId::User

crates/bitwarden-vault/src/folder/folder_models.rs

@@ -38,7 +38,7 @@ log = "0.4.20"
 serde = { workspace = true }
 tsify = { workspace = true }
 # When upgrading wasm-bindgen, make sure to update the version in the workflows!
-wasm-bindgen = { version = "=0.2.100", features = ["serde-serialize"] }
+wasm-bindgen = { version = "=0.2.105", features = ["serde-serialize"] }
 wasm-bindgen-futures = "0.4.41"
 
 [lints]

crates/bitwarden-wasm-internal/Cargo.toml

@@ -63,4 +63,4 @@ npx terser ./crates/bitwarden-wasm-internal/${NPM_FOLDER}/bitwarden_wasm_interna
 
 # Typecheck the generated TypeScript definitions
 cd crates/bitwarden-wasm-internal/${NPM_FOLDER}
-npx tsc --noEmit --lib es2020,dom bitwarden_wasm_internal.d.ts
+npx tsc --noEmit --lib es2020,dom,ESNext.Disposable bitwarden_wasm_internal.d.ts