[PM-23785] Use actual error types in UniFFI (#424)

## 🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23785

## 📔 Objective

Currently all the UniFFI errors get serialized as a string. This PR
updates UniFFI to the latest main changes to add support for proper
errors. This requires a couple of changes:

- I've tagged all the errors with `uniffi::Error` and added support to
the bitwarden-error macro for uniffi.
- I've had to add some workaround code to deal with an edge case that
caused some compilation issues, more info upstream:
mozilla/uniffi-rs#2636
- Updated the gradle wrapper included as the old version was having some
issues with my java version


How this looks on the mobile apps:
Android:
```kt
try {
    client.crypto().deriveKeyConnector(request)
} catch (ex: BitwardenException.DeriveKeyConnector) {
    when (ex.v1) {
        is DeriveKeyConnectorException.WrongPassword -> {
            println("That is the wrong password: $ex")
        }
        else -> {
            println("Other bitwarden error: ${ex.v1}")
        }
    }
} catch (ex: BitwardenException) {
    println("Other bitwarden error: $ex")
}
```

iOS:
```swift
do {
    try client.crypto().deriveKeyConnector(request);
} catch(BitwardenError.DeriveKeyConnector(DeriveKeyConnectorError.WrongPassword(let msg))) {
    print("Wrong password:", msg)
} catch {
    print("Other bitwarden error:", error)
}
```

## ⏰ Reminders before review

- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or
informed the documentation
  team

## 🦮 Reviewer guidelines

<!-- Suggested interactions but feel free to use (or not) as you desire!
-->

- 👍 (`:+1:`) or similar for great changes
- 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info
- ❓ (`:question:`) for questions
- 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry
that's not quite a confirmed
  issue and could potentially benefit from discussion
- 🎨 (`:art:`) for suggestions / improvements
- ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or
concerns needing attention
- 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or
indications of technical debt
- ⛏ (`:pick:`) for minor or nitpick changes

Author: dani-garcia

Cargo.lock

@@ -78,7 +78,7 @@ tokio = { version = "1.36.0", features = ["macros"] }
 tsify = { version = ">=0.5.5, <0.6", features = [
     "js",
 ], default-features = false }
-uniffi = "=0.29.1"
+uniffi = "=0.29.4"
 uuid = { version = ">=1.3.3, <2.0", features = ["serde", "v4", "js"] }
 validator = { version = ">=0.18.1, <0.21", features = ["derive"] }
 wasm-bindgen = { version = ">=0.2.91, <0.3", features = ["serde-serialize"] }
@@ -92,13 +92,23 @@ wiremock = ">=0.6.0, <0.7"
 [patch.crates-io]
 pkcs5 = { git = "https://github.com/bitwarden/rustcrypto-formats.git", rev = "2b27c63034217dd126bbf5ed874da51b84f8c705" }
 
+uniffi = { git = "https://github.com/mozilla/uniffi-rs", rev = "6d46b3f756dde3213357c477d86771a0fc5da7b4" }
+uniffi_core = { git = "https://github.com/mozilla/uniffi-rs", rev = "6d46b3f756dde3213357c477d86771a0fc5da7b4" }
+uniffi_macros = { git = "https://github.com/mozilla/uniffi-rs", rev = "6d46b3f756dde3213357c477d86771a0fc5da7b4" }
+uniffi_internal_macros = { git = "https://github.com/mozilla/uniffi-rs", rev = "6d46b3f756dde3213357c477d86771a0fc5da7b4" }
+uniffi_bindgen = { git = "https://github.com/mozilla/uniffi-rs", rev = "6d46b3f756dde3213357c477d86771a0fc5da7b4" }
+uniffi_build = { git = "https://github.com/mozilla/uniffi-rs", rev = "6d46b3f756dde3213357c477d86771a0fc5da7b4" }
+
 [workspace.lints.clippy]
 unused_async = "deny"
 unwrap_used = "deny"
 string_slice = "warn"
 
 [workspace.lints.rust]
 missing_docs = "warn"
+unexpected_cfgs = { level = "warn", check-cfg = [
+    'cfg(feature, values("uniffi", "wasm"))',
+] }
 
 [workspace.metadata.dylint]
 libraries = [{ path = "support/lints" }]

Cargo.toml

@@ -15,7 +15,6 @@ license-file.workspace = true
 keywords.workspace = true
 
 [features]
-uniffi = ["bitwarden-core/uniffi", "dep:uniffi"] # Uniffi bindings
 wasm = [
     "bitwarden-core/wasm",
     "dep:tsify",
@@ -32,7 +31,6 @@ reqwest = { workspace = true }
 serde = { workspace = true }
 thiserror = { workspace = true }
 tsify = { workspace = true, optional = true }
-uniffi = { workspace = true, optional = true }
 wasm-bindgen = { workspace = true, optional = true }
 wasm-bindgen-futures = { workspace = true, optional = true }
 

crates/bitwarden-auth/Cargo.toml

@@ -206,6 +206,7 @@ impl AuthClient {
 #[allow(missing_docs)]
 #[cfg(feature = "internal")]
 #[derive(Debug, thiserror::Error)]
+#[cfg_attr(feature = "uniffi", derive(uniffi::Error), uniffi(flat_error))]
 pub enum TrustDeviceError {
     #[error(transparent)]
     Crypto(#[from] bitwarden_crypto::CryptoError),

crates/bitwarden-core/src/auth/auth_client.rs

@@ -75,6 +75,7 @@ pub(crate) fn auth_request_decrypt_master_key(
 
 #[allow(missing_docs)]
 #[derive(Debug, Error)]
+#[cfg_attr(feature = "uniffi", derive(uniffi::Error), uniffi(flat_error))]
 pub enum ApproveAuthRequestError {
     #[error(transparent)]
     Crypto(#[from] CryptoError),

crates/bitwarden-core/src/auth/auth_request.rs

@@ -51,6 +51,7 @@ pub use key_connector::KeyConnectorResponse;
 /// Error for authentication related operations
 #[allow(missing_docs)]
 #[derive(Debug, Error)]
+#[cfg_attr(feature = "uniffi", derive(uniffi::Error), uniffi(flat_error))]
 pub enum AuthValidateError {
     #[error(transparent)]
     NotAuthenticated(#[from] NotAuthenticatedError),

crates/bitwarden-core/src/auth/mod.rs

@@ -30,6 +30,7 @@ macro_rules! impl_bitwarden_error {
 /// Errors from performing network requests.
 #[allow(missing_docs)]
 #[derive(Debug, Error)]
+#[cfg_attr(feature = "uniffi", derive(uniffi::Error), uniffi(flat_error))]
 pub enum ApiError {
     #[error(transparent)]
     Reqwest(#[from] reqwest::Error),

crates/bitwarden-core/src/error.rs

@@ -33,6 +33,7 @@ pub struct FingerprintResponse {
 /// Errors that can occur when computing a fingerprint.
 #[allow(missing_docs)]
 #[derive(Debug, Error)]
+#[cfg_attr(feature = "uniffi", derive(uniffi::Error))]
 pub enum FingerprintError {
     #[error(transparent)]
     Crypto(#[from] bitwarden_crypto::CryptoError),
@@ -48,6 +49,7 @@ pub(crate) fn generate_fingerprint(input: &FingerprintRequest) -> Result<String,
 /// Errors that can occur when computing a fingerprint.
 #[allow(missing_docs)]
 #[derive(Debug, Error)]
+#[cfg_attr(feature = "uniffi", derive(uniffi::Error), uniffi(flat_error))]
 pub enum UserFingerprintError {
     #[error(transparent)]
     Crypto(#[from] bitwarden_crypto::CryptoError),

crates/bitwarden-core/src/platform/generate_fingerprint.rs

@@ -41,6 +41,7 @@ pub(crate) fn bitwarden_error_flat(
             });
 
             quote! {
+                #[cfg_attr(feature = "uniffi", derive(uniffi::Error), uniffi(flat_error))]
                 #input
                 #wasm
 

crates/bitwarden-error-macro/src/flat/attribute.rs

@@ -21,6 +21,7 @@ pub(crate) fn bitwarden_error_full(
 
     quote! {
         #[derive(serde::Serialize)]
+        #[cfg_attr(feature = "uniffi", derive(uniffi::Error))]
         #wasm_attributes
         #input
     }