Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/Schema mismatch for Note's channel attribute requirement #63

Open
Veratil opened this issue Oct 3, 2023 · 1 comment
Open
Assignees

Comments

@Veratil
Copy link

Veratil commented Oct 3, 2023

Project.xsd has <Note channel=...> as a required attribute, but the documentation states it's not required since the code has it defined as not required.

I believe the schema is wrong and we really don't want channel as a required attribute (and I'd prefer it not required 🙂).

@kurasu kurasu self-assigned this Oct 4, 2023
@kurasu
Copy link
Member

kurasu commented Oct 4, 2023

You are correct, it should not be required. It seems the Jakarta library used to generate the XSD from the Java code always makes it required unless it's an object type. In the source it was explicitly set to be optional.

/** MIDI channel of this note. */ @XmlAttribute(required = false) public int channel;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants