Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename targets and schemes #62

Closed
bizz84 opened this issue Aug 4, 2016 · 0 comments
Closed

Rename targets and schemes #62

bizz84 opened this issue Aug 4, 2016 · 0 comments
Labels
type: enhancement

Comments

@bizz84
Copy link
Owner

bizz84 commented Aug 4, 2016 •
edited
Loading

Following the addition of OSX (now macOS) and tvOS compatibility, it seems to appropriate to rename the targets and schemes as follows:

  • SwiftyStoreKit -> SwiftyStoreKitIOS
  • SwiftyStoreKitOSX -> SwiftyStoreKitMacOS
  • SwiftyStoreKitTV -> SwiftyStoreKitTvOS

This should not be a code breaking change for clients as the module would be imported as import SwiftyStoreKit as before.

The folder structure could also be updated:

  • Introduce SwiftyStoreKitIOS folder to include SwiftyStoreKitIOS.h and Info.plist files.
  • Rename SwiftyStoreKitOSX folder to SwiftyStoreKitMacOS
  • Rename SwiftyStoreKitTV folder to SwiftyStoreKitTvOS
  • Rename SwiftyStoreDemo folder to SwiftyStoreKitDemoIOS
  • Rename SwiftyStoreOSXDemo folder to SwiftyStoreKitDemoMacOS

The above should bring more consistency to the naming conventions in SwiftyStoreKit. Feedback is appreciated about this proposal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bizz84