fix: isLoading has correct status when autoSignIn is disabled and user is signed out #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibly fixes bjerkio#980 but doubtful
simenandre
approved these changes
Mar 21, 2023
This was referenced Mar 21, 2023
|
Oh super, I literally just ran into this bug. Thanks for fixing it 😄 Just wondering when it's intended to be released? or are you still working on v4? |
|
@South-Paw something went wrong in the normal release mechanism. Hopefully once #987 is merged, then a new 3.0.4 release will be published to npm! |
This was referenced Mar 22, 2023
|
@jamesdh and @South-Paw: Should be fixed now! |
|
Thanks all! 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #981, may also fix #980 (although doubtful).