Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vs2017 objdir produces incorrect path #344

Open
ssexton71 opened this issue Feb 17, 2018 · 2 comments
Open

vs2017 objdir produces incorrect path #344

ssexton71 opened this issue Feb 17, 2018 · 2 comments

Comments

@ssexton71
Copy link

Given an objdir that would produce a relative path with the VS2015 generator (in my case, ".objs/x64"), the VS2017 generator produces an incorrect absolute path.

The problem is with the IntDirIsAbsolute flag added in 78fc15a. Building a path using prj.solution.location is incorrect: if there is >1 project in the solution (very common), it generates the same absolute path for all projects, which causes warnings and possibly build errors. It should be caculated from the prjoect path.

As best I can tell, the IntDirIsAbsolute workaround is not needed, and should be removed. In the meantime as a klunky workaround for this bug, use the (working) vs2015 generator and upgrade it inside Visual Studio.

@bkaradzic
Copy link
Owner

bkaradzic commented Feb 17, 2018

As best I can tell, the IntDirIsAbsolute workaround is not needed, and should be removed.

Sounds good, submit PR with proper fix.

@forrestthewoods
Copy link

Just ran into this issue myself. @ssexton71, did you ever put together a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@bkaradzic @ssexton71 @forrestthewoods and others