Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken highlighting #10

Open
loganswartz opened this issue Aug 31, 2021 · 4 comments · May be fixed by #15
Open

Broken highlighting #10

loganswartz opened this issue Aug 31, 2021 · 4 comments · May be fixed by #15

Comments

@loganswartz
Copy link

I've found some instances where highlighting breaks.

Some instances of the string on contained in another string are erroneously highlighted:
Screenshot from 2021-08-31 16-47-29

Same issue here, and also some of the directives aren't highlighted correctly.
Screenshot from 2021-08-31 16-56-40

@bkegley
Copy link
Owner

bkegley commented Aug 31, 2021

Thanks! The on error makes sense and is an easy fix.

Would you be able to inspect the directives using nvim-treesitter/playground and let me know if the grammar isn't identifying them correctly? Sometimes highlighting can break even when the grammar is correctly identifying the string.

@loganswartz
Copy link
Author

Looks like it's a grammar error, not just erroneous highlighting. Here's what I'm seeing:
Screenshot from 2021-08-31 19-07-09
Here's the corresponding highlighted node:
Screenshot from 2021-08-31 19-09-20

If you don't want to type out that snippet from the picture, here's a copy-paste:

input ShipmentFilter {
    ids: [ID] @in(key: "shipments.id")
    city: String @builder(method: "App\\GraphQL\\Controllers\\ShipmentController@hasCity") @like
    state: String @builder(method: "App\\GraphQL\\Controllers\\ShipmentController@hasState") @like
    consignor: String @builder(method: "App\\GraphQL\\Controllers\\ShipmentController@hasConsignor") @like
    consignee: String @builder(method: "App\\GraphQL\\Controllers\\ShipmentController@hasConsignee") @like
    isShipped: Boolean @scope(name: "isShipped") @rules(apply: ["boolean"])
    location: ID @scope(name: "inLocation")
    orderBy: [OrderByClause!] @orderBy
}

@loganswartz
Copy link
Author

Any update on this?

@loganswartz
Copy link
Author

@bkegley it's been a year, any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants