Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the values for ChronoUnit be kebab case? #335

Closed
mdedetrich opened this issue Aug 15, 2021 · 2 comments
Closed

Should the values for ChronoUnit be kebab case? #335

mdedetrich opened this issue Aug 15, 2021 · 2 comments

Comments

@mdedetrich
Copy link
Contributor

After discussion at #331 for adding ChronoUnit to pureconfig, a good point was made in that rather then the appropriate values for ChronoUnit being snake case they should instead be kebab case (or maybe something else more appropriate). The value that this effects is

HALF_DAYS("HalfDays", Duration.ofSeconds(43200))

Currently with my PR at #331 we accept either HALF_DAYS or half_days but maybe another format such as half-days is more appropriate.

There is also a discussion whether rather than accepting both HALF_DAYS and half_days that instead we should only accept a single standard format.

@bkirwi
Copy link
Owner

bkirwi commented Aug 20, 2021

I don't have strong feelings on this one... leaning towards being as generous as possible in what we accept, since there's no clear winner, but open to the other approaches as well.

@mdedetrich
Copy link
Contributor Author

Will close this for now, if we decide to do something more fancy like whats done with pureconf a separate generic issue should be made about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants