Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CommandIOApp a trait #464

Open
armanbilge opened this issue Nov 16, 2022 · 1 comment
Open

Make CommandIOApp a trait #464

armanbilge opened this issue Nov 16, 2022 · 1 comment
Labels
breaking

Comments

@armanbilge
Copy link
Contributor

armanbilge commented Nov 16, 2022 •
edited
Loading

This would avoid issues like #461 in the future.

Note that making an abstract class a trait is a binary-incompatible change, so this may require a major version bump for decline.
@bkirwi
Copy link
Owner

bkirwi commented Nov 18, 2022

Hmm... I don't love the impact that has on the API, but possible it's worth it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkirwi @armanbilge