Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to see last months map so you can see who you talked to last time i.e. unique event urls #7

Closed
djay opened this issue Jul 27, 2017 · 5 comments
Labels

Comments

@djay
Copy link
Contributor

djay commented Jul 27, 2017

maybe http://hackmap.com/bkkhack/events/7
and http://hackmap.com/bkkhack/events redirects based on the label?

Implicit in the above urls is if the repo name should be in the url. Pro: allows the code to reused for any repo without forking. con: allows the code to reused with any repo without forking, could have problems with oauth? :)

@djay djay changed the title ability to see last months map so you can see who you talked to last time ability to see last months map so you can see who you talked to last time i.e. unique event urls Aug 23, 2017
@djay
Copy link
Contributor Author

djay commented Aug 30, 2017

@waf if the same code is used for many events/repos, what are the implications of oauth?

@waf
Copy link
Member

waf commented Sep 28, 2017

@djay The oauth application registered with GitHub needs a single callback url that must match exactly. So each event/repo would need its own application, and its own endpoint running gatekeeper

@djay
Copy link
Contributor Author

djay commented Sep 29, 2017

@waf can't people login to http://hackmap.com/bkkhack and then we redirect after that?
Otherwise it would be really restrictive.
Or else we could do http://hackmap.com/bkkhack?map=20170801&userid=djay or http://hackmap.com/bkkhack#!20170801/djay

@djay
Copy link
Contributor Author

djay commented Apr 2, 2018

@waf This discussion kind of got side tracked... but the need is still there.
What would be super useful is to send out a url to everyone saying here is last month, see what interesting things people did and here is another url for this month...

@waf
Copy link
Member

waf commented Apr 2, 2018

@djay I just merged #62 which fixed the current issues with the routing, and deployed it.

Example URLs:

See the PR for the explanation about the hash in the URL.

Earlier hacknights, which relied on us editing the source code to update the floorplan image, don't work. The later hacknights, where we embedded the map url in the issue comment, do work.

@waf waf closed this as completed Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants