-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ability to see last months map so you can see who you talked to last time i.e. unique event urls #7
Comments
@waf if the same code is used for many events/repos, what are the implications of oauth? |
@djay The oauth application registered with GitHub needs a single callback url that must match exactly. So each event/repo would need its own application, and its own endpoint running gatekeeper |
@waf can't people login to http://hackmap.com/bkkhack and then we redirect after that? |
@waf This discussion kind of got side tracked... but the need is still there. |
@djay I just merged #62 which fixed the current issues with the routing, and deployed it. Example URLs:
See the PR for the explanation about the hash in the URL. Earlier hacknights, which relied on us editing the source code to update the floorplan image, don't work. The later hacknights, where we embedded the map url in the issue comment, do work. |
maybe http://hackmap.com/bkkhack/events/7
and http://hackmap.com/bkkhack/events redirects based on the label?
Implicit in the above urls is if the repo name should be in the url. Pro: allows the code to reused for any repo without forking. con: allows the code to reused with any repo without forking, could have problems with oauth? :)
The text was updated successfully, but these errors were encountered: