fix(components/datetime): resources strings for default calculators are not resolved in the service #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-SteveBrush
added
the
risk level (author): 3
…re not resolved in the service
Blackbaud-SteveBrush
force-pushed
the
date-range-service-no-resolve-resources
branch
from
fdb4985
to
39be5c6
Compare
Blackbaud-SteveBrush
changed the title
|
Component Storybooks: Apps: |
Blackbaud-TrevorBurch
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#2930286
BREAKING CHANGE
Resources strings for the default calculators'
shortDescriptionproperty are resolved in the date range picker's template, but any consumers expecting theshortDescriptionvalues to be resolved in theSkyDateRangeServicewill need to change assertions in their unit tests.