-
Notifications
You must be signed in to change notification settings - Fork 65
Port over the error component #156
Comments
I've started working on this issue. |
Where should I put the default error images? Should I put them in the local fixtures folder? |
Not sure if fixtures is the right place for this, that's more for where we have test artifacts. In SKY UX 1, we had an images folder where we kept the images, and the css classes referenced them as background images. @Blackbaud-BobbyEarl or @Blackbaud-PaulCrowder is that the approach we should take here? |
The build process would then place an images folder with all images in the css folder in dist |
Does anyone have objections to me moving forward with @Blackbaud-PatrickOFriel's solution? |
Hey @Blackbaud-AdamHickey we talked a bit and we decided that for the time being we want to use base64 encoding of the images in our css. This way we don't have to worry about how builder will handle images just yet and we can solve the problem specifically for the error component. I'd use a tool like http://b64.io/ to do the encoding and just paste it into the appropriate class in your error.scss file. |
Thanks @Blackbaud-PatrickOFriel. Sounds good. |
In 2.0.0-beta.11 |
No description provided.
The text was updated successfully, but these errors were encountered: