Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Port over the error component #156

Closed
Blackbaud-PatrickOFriel opened this issue Oct 21, 2016 · 8 comments
Closed

Port over the error component #156

Blackbaud-PatrickOFriel opened this issue Oct 21, 2016 · 8 comments

Comments

@Blackbaud-PatrickOFriel
Copy link
Contributor

No description provided.

@Blackbaud-AdamHickey
Copy link
Contributor

I've started working on this issue.

@Blackbaud-AdamHickey
Copy link
Contributor

Where should I put the default error images? Should I put them in the local fixtures folder?

@Blackbaud-PatrickOFriel
Copy link
Contributor Author

Not sure if fixtures is the right place for this, that's more for where we have test artifacts. In SKY UX 1, we had an images folder where we kept the images, and the css classes referenced them as background images. @Blackbaud-BobbyEarl or @Blackbaud-PaulCrowder is that the approach we should take here?

@Blackbaud-PatrickOFriel
Copy link
Contributor Author

The build process would then place an images folder with all images in the css folder in dist

@Blackbaud-AdamHickey
Copy link
Contributor

Does anyone have objections to me moving forward with @Blackbaud-PatrickOFriel's solution?

@Blackbaud-PatrickOFriel
Copy link
Contributor Author

Hey @Blackbaud-AdamHickey we talked a bit and we decided that for the time being we want to use base64 encoding of the images in our css. This way we don't have to worry about how builder will handle images just yet and we can solve the problem specifically for the error component. I'd use a tool like http://b64.io/ to do the encoding and just paste it into the appropriate class in your error.scss file.

@Blackbaud-AdamHickey
Copy link
Contributor

Thanks @Blackbaud-PatrickOFriel. Sounds good.

@Blackbaud-PatrickOFriel
Copy link
Contributor Author

In 2.0.0-beta.11

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants