-
Notifications
You must be signed in to change notification settings - Fork 65
Icon checkboxes missing text equivalent labels (1.1.1) #2234
Comments
@Blackbaud-MattGregg looking into this I think this one is simply that our demo doesn't go far enough to show how things work. The If I'm understanding correctly we just need to update the demo to show how to use this property. Am I correct in that? |
@Blackbaud-TrevorBurch When I view this one in the demo and in Plunkr, the label values are being set in the JS class, but the aria-label="" is empty then in the HTML output. @blackbaud-johnly This component doesn't seem to have any documentation of properties like the radio button? |
I created an issue to document the properties: #2258. |
@Blackbaud-MattGregg I made blackbaud/skyux-forms#14 to address the empty attribute problem. All other places where we use the |
Demo has been updated. Closing since we have a separate issue for the docs portion. |
Expected behavior
Labels are in the markup in the aria-label= property.
Actual behavior
The value in the TS file is not coming through in the markup produced (at least in the demo). The aria-label="" is blank.
Steps to reproduce
Go to https://developer.blackbaud.com/skyux/components/checkbox and inspect icon checkboxes
The text was updated successfully, but these errors were encountered: