Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Modal content height is not bound #361

Closed
Blackbaud-PatrickOFriel opened this issue Feb 15, 2017 · 2 comments
Closed

Modal content height is not bound #361

Blackbaud-PatrickOFriel opened this issue Feb 15, 2017 · 2 comments
Assignees

Comments

@Blackbaud-PatrickOFriel
Copy link
Contributor

Blackbaud-PatrickOFriel commented Feb 15, 2017

If the modal content gets very large, then the footer is not visible on the screen. We should do something to specify a max-height on the content so that it scrolls and the footer is always shown.

Example:
https://plnkr.co/edit/V5tAoH4TkZlAErdJMyH8?p=preview

@Blackbaud-PatrickOFriel
Copy link
Contributor Author

A good way to accomplish this might be the following:

.sky-modal class additions:

  • display: flex
  • flex-direction: column

.sky-modal-header

  • flex-shrink: 0

.sky-modal-content

  • overflow-y: auto

.sky-modal-footer

  • flex-shrink: 0

Then all you have to do is set the max-height of the sky-modal class based on the window height (by watching window height change event)

@Blackbaud-PatrickOFriel
Copy link
Contributor Author

In 2.0.0-beta.11

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant