Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

sky-action-button doesn't load font-awesome class before use in HTML #382

Closed
blackbaud-joshlandi opened this issue Feb 23, 2017 · 3 comments
Assignees

Comments

@blackbaud-joshlandi
Copy link

Expected behavior

this.fontSizeClass should be set before the template uses it and the icon should be styled appropriately.

Actual behavior

Possible race condition with .subscribe() where call to service doesn't fully resolve before template uses the fontSizeClass property.

Steps to reproduce

  • Have SPA or site with multiple tabs
  • Have a sky-action-button element with an icon
  • Visit tab containing element
  • Visit another tab
  • Go back to tab containing sky-action-button
  • Notice errors in console
@Blackbaud-PatrickOFriel
Copy link
Contributor

Hey @blackbaud-joshlandi, did you want to try to write a pull request for this, or do you want me to grab it this week?

@blackbaud-joshlandi
Copy link
Author

@Blackbaud-PatrickOFriel you can go ahead and grab it this week. I was gonna do it last week, but got hung up on other stuff. Thanks!

@Blackbaud-PatrickOFriel
Copy link
Contributor

In 2.0.0-beta.10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants