Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Modals with enough content to scroll do not scroll in IE11 #564

Closed
Blackbaud-LuisBello opened this issue Apr 7, 2017 · 5 comments
Closed
Assignees

Comments

@Blackbaud-LuisBello
Copy link
Contributor

Blackbaud-LuisBello commented Apr 7, 2017

I wish i could show you a plunker, but you know, your plunkers dont work on IE11.

this was tested on WIndows 10 64 bit, IE 11 latest version.

@Blackbaud-PatrickOFriel
Copy link
Contributor

Didn't know our plunkers don't work in IE11, I'll make an issue to address that. For the IE11 modal issue, apparently IE11 has a bug flex doesn't work well with max-height. So we might have to do a workaround since Microsoft isn't updating IE11 anymore, they just point everyone to Edge when there are issues. We'll have to take a look at some workarounds to fix this specific issue

@Blackbaud-LuisBello
Copy link
Contributor Author

what is the max height you're setting on .sky-modal-content? the issue here, at least using the skyux package, is that .sky-modal-content has overflow-y: auto on it, but no height or max height. overflow-y:auto does not work on IE unless you have height or max height set

@Blackbaud-PatrickOFriel
Copy link
Contributor

Well the thing that's happening here is we have a max-height on the display: flex parent of sky-modal-content. As a flex child the sky-modal-content be bounded as well. The bug is this: https://connect.microsoft.com/IE/feedback/details/802625/min-height-and-flexbox-flex-direction-column-dont-work-together-in-ie-10-11-preview. In the end, we'll probably end up having to put a max-height on the sky-modal-content as well to deal with IE 11 quirks, but I had wanted to avoid that originally.

@Blackbaud-LuisBello
Copy link
Contributor Author

it's a good thought to avoid doing so, as I'm seeing now. adding a max height will work for a set resolution, but if you then lower resolution it pushes the footer of the modal off screen if you made the max-height to fit nicely to the original resolution

@Blackbaud-PatrickOFriel
Copy link
Contributor

In 2.0.0-beta.18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants