Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Sky Grid Calling Data Provider Multiple Times When Columns Change #683

Closed
Blackbaud-TrevorBurch opened this issue May 12, 2017 · 4 comments

Comments

@Blackbaud-TrevorBurch
Copy link
Member

Expected behavior

When the columns are changed for a grid I would only expect one call at maximum to the data provider to get new info

Actual behavior

When the columns are changed for a grid with a data provider it is making multiple calls to the data provider which would potentially cause multiple async calls to get data for the grid.

Steps to reproduce

Setup a grid with initial columns
Change the columns in some manner to new columns
Observe multiple calls being made to the data provider (through logs or breakpoints)

Plunker

https://plnkr.co/edit/ATRZfehwjXOY9Ul0jxKe?p=preview

@Blackbaud-PatrickOFriel
Copy link
Contributor

This is probably going to be pretty difficult to solve with the way getting and setting data in lists currently works (basically by watching changes to objects on observables). I think I'll try to solve this while working on this issue (#598) where I'm going to take a look at how the list interacts with data in general

@blackbaud-brandonstirnaman

Have reproduced this in the ME Contrib version of this Grid as well. The gizmoduck team will take a look at this and fix in both controls. @blackbaud-joshgerdes @Blackbaud-LuisBello

@Blackbaud-LuisBello
Copy link
Contributor

Blackbaud-LuisBello commented Aug 8, 2017

#982

the above PR provides a fix for this issue

@Blackbaud-TrevorBurch
Copy link
Member Author

@Blackbaud-SteveBrush is this ready to be closed now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants