This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 65
Sky Grid Calling Data Provider Multiple Times When Columns Change #683
Labels
Comments
Blackbaud-PatrickOFriel
modified the milestones:
Block 3 Sprint 4 - 5/19/2017,
Block 3 Sprint 6 - 6/9/2017
May 15, 2017
This is probably going to be pretty difficult to solve with the way getting and setting data in lists currently works (basically by watching changes to objects on observables). I think I'll try to solve this while working on this issue (#598) where I'm going to take a look at how the list interacts with data in general |
Blackbaud-PatrickOFriel
modified the milestones:
Block 4 Sprint 6 - 7/28/2017,
Block 4 Sprint 5 - 7/21/2017
Jul 24, 2017
Have reproduced this in the ME Contrib version of this Grid as well. The gizmoduck team will take a look at this and fix in both controls. @blackbaud-joshgerdes @Blackbaud-LuisBello |
the above PR provides a fix for this issue |
@Blackbaud-SteveBrush is this ready to be closed now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Expected behavior
When the columns are changed for a grid I would only expect one call at maximum to the data provider to get new info
Actual behavior
When the columns are changed for a grid with a data provider it is making multiple calls to the data provider which would potentially cause multiple async calls to get data for the grid.
Steps to reproduce
Setup a grid with initial columns
Change the columns in some manner to new columns
Observe multiple calls being made to the data provider (through logs or breakpoints)
Plunker
https://plnkr.co/edit/ATRZfehwjXOY9Ul0jxKe?p=preview
The text was updated successfully, but these errors were encountered: