Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Console error on sorting a grid in IE 11 #891

Closed
Blackbaud-TrevorBurch opened this issue Jul 14, 2017 · 2 comments
Closed

Console error on sorting a grid in IE 11 #891

Blackbaud-TrevorBurch opened this issue Jul 14, 2017 · 2 comments
Assignees

Comments

@Blackbaud-TrevorBurch
Copy link
Member

Expected behavior

When I click on a column header I would expect the grid to sort and no console errors to be thrown.

Actual behavior

When the column header is clicked on the grid is sorted correctly; however, there is a console error thrown in IE 11.

ERROR TypeError: Object doesn't support property or method 'matches'

Steps to reproduce

  1. Go to the Sky 2 docs in IE 11 for Grid
  2. Open the developer tools
  3. Click on the first column's header
  4. Observe the error in the developer tools

Plunker

Can see on Sky docs

@Blackbaud-PatrickOFriel
Copy link
Contributor

Looks like a strange thing happening with dragula only in IE11 where handle is not defined. All we need to do is a check if handle is undefined before the .matches function is called https://github.com/blackbaud/skyux2/blob/master/src/modules/grid/grid-adapter.service.ts#L38

@Blackbaud-PatrickOFriel
Copy link
Contributor

In 2.0.0-rc.6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants