Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Upgrade moment package #1531

Merged
merged 5 commits into from
Mar 8, 2018
Merged

Upgrade moment package #1531

merged 5 commits into from
Mar 8, 2018

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Mar 7, 2018 •
edited
Loading

  • Upgraded moment to satisfy the "vulnerable dependency" warning for moment.
  • I noticed that the Timepicker component's HTML template is referencing private properties, so I made those public.

@codecov-io
Copy link

codecov-io commented Mar 7, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@c98f349). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1531   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?     387           
  Lines             ?    7568           
  Branches          ?     970           
========================================
  Hits              ?    7568           
  Misses            ?       0           
  Partials          ?       0
Impacted Files Coverage Δ
src/modules/list/state/items/items.orchestrator.ts 100% <100%> (ø)
src/modules/timepicker/timepicker.directive.ts 100% <100%> (ø)
src/modules/list/list.component.ts 100% <100%> (ø)
...dules/list/state/selected/selected.orchestrator.ts 100% <100%> (ø)
...nk-records/state/selected/selected.orchestrator.ts 100% <100%> (ø)
...provider-in-memory/list-data-in-memory.provider.ts 100% <100%> (ø)
src/modules/timepicker/timepicker.component.ts 100% <100%> (ø)
...st-view-grid/state/columns/columns.orchestrator.ts 100% <100%> (ø)
...link-records/state/results/results.orchestrator.ts 100% <100%> (ø)
...rc/modules/datepicker/datepicker-config.service.ts 100% <100%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98f349...66b897c. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 91ade69 into master Mar 8, 2018
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the upgrade-moment branch March 8, 2018 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl Blackbaud-BobbyEarl approved these changes

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder Awaiting requested review from Blackbaud-PaulCrowder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blackbaud-SteveBrush @codecov-io @Blackbaud-BobbyEarl