This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Toolbar with search #328
Merged
Toolbar with search #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - tweak input-group and search styles to not use table display since we can use flex instead. - Used toolbar component in search demo. TODO: - toolbar unit tests - toolbar visual tests - toolbar docs - use toolbar in list-toolbar component
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 194
Lines ? 2988
Branches ? 301
=======================================
Hits ? 2988
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
TODO: - list view grid test for provided search function - toolbar load action index test - docs for column search function - docs for view grid search function - refine list-toolbar docs - action button test coverage
Blackbaud-PatrickOFriel
requested review from
Blackbaud-BobbyEarl,
Blackbaud-PaulCrowder and
Blackbaud-TerryHelems
Blackbaud-BobbyEarl
approved these changes
Feb 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#312