Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle closing terminal #2

Open
blairj09 opened this issue Apr 20, 2018 · 0 comments
Open

Handle closing terminal #2

blairj09 opened this issue Apr 20, 2018 · 0 comments

Comments

@blairj09
Copy link
Owner

Currently, when a new docker container is initialized, a new terminal window is used in RStudio. When the docker container is exited, the container is removed from docker (it's a temporary container) but the terminal window remains open in RStudio. This isn't a huge issue, but it due to the way dockerterm labels terminal windows, if a user starts a new Docker container with the same image without previously closing the open terminal an error will occur.

Handling the closing of the terminal window within dockerterm may entail keeping the app running until explicitly told to exit, at which point the container is shut down and the terminal window is closed. This solution would freeze the user's host R session while the application was being run, but the user would still be able to run R code against the docker container. The question is, is this desirable functionality or is it better to allow the user to run R code against the host R session and the docker R session?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant