Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of 'real' #205

Open
jcrist opened this issue Jan 5, 2016 · 0 comments
Open

Inconsistent use of 'real' #205

jcrist opened this issue Jan 5, 2016 · 0 comments

Comments

@jcrist
Copy link
Member

jcrist commented Jan 5, 2016

Datashape has 3 things using the word "real" in them:

  • ds.predicates.isreal: checks if the datashape is floating point
  • ds.real: alias for ctype("float64")
  • ds.typesets.real: contains all numeric, non-complex types

This is inconsistent, and should be corrected. I'd prefer to make ds.predicates.isreal check for containment in ds.typesets.real (expanding isreal to return True for integers). Removing the alias may or may not be beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant