Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options with numbers for RocksDB are all casted as float64. #39

Open
cv711 opened this issue Jan 9, 2018 · 1 comment
Open

Options with numbers for RocksDB are all casted as float64. #39

cv711 opened this issue Jan 9, 2018 · 1 comment

Comments

@cv711
Copy link
Contributor

cv711 commented Jan 9, 2018

Any particular reason for this one?

Users usually don't expect setting the log level like this "info_log_level" : 3.0, and if you use an int casting it fails and the option is never set

@mschoch
Copy link
Contributor

mschoch commented Jan 9, 2018

The code is ancient and dates back to a time when there was a misunderstanding about how JSON parsing worked in Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants