Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin only uses link to first recording element #88

Open
Be-El opened this issue Apr 22, 2020 · 4 comments
Open

Plugin only uses link to first recording element #88

Be-El opened this issue Apr 22, 2020 · 4 comments

Comments

@Be-El
Copy link

Be-El commented Apr 22, 2020

We are using a little cluster of BBB backend and a scalelite load balancer. We have configured to backend to record all possible sources (presentation, audio, video, screenshare, notes) by installing the corresponding plugins.

The plugin works in this setup, but only uses the first available format. In most cases this is not the expected one (see https://github.com/blindsidenetworks/mattermost-plugin-bigbluebutton/blob/master/server/responsehandlers.go#L544).

It seems that the API between the server side and the web client only supports a single link; in case of our setup we need a list of links for the different types. The thumbnails are also broken in most cases, since they also only refer to the first link without taking its format into account.

@ghost
Copy link

ghost commented May 10, 2020

@Be-El the recording link your receive in MM shows both screens shared webcam recording. Is that not the case with your setup?

@greatfireball
Copy link

Indeed, in our setup the Podcast is always the first recording returened and therefore will be linked here. I created a fix which displays different types. I can create a pull request if you would like to.

@Be-El
Copy link
Author

Be-El commented May 11, 2020

Our setup is also not a simple BBB, but a scalelite load balancer and several BBB endpoints. The API requests to retrieve the recordings are sent to scalelite; maybe the API or the scalelite collector uses a different order in the underlying XML file.

@harshilsharma63
Copy link
Contributor

harshilsharma63 commented May 30, 2021

@greatfireball feel free to create a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants