-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add createVC RPC method #141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudobun
previously approved these changes
Mar 24, 2023
martines3000
approved these changes
Mar 28, 2023
martines3000
added a commit
that referenced
this pull request
Apr 6, 2023
* feat: update types * feat: add createVC RPC method * fix: add bip44CoinTypeNode * test: add params tests * chore: fix tests * feat: add createVC to connector * fix: wrong return type * fix: pr feedback * chore: move queryVCsRequestResult[] type in test * fix: change it.todo in tests * chore: update remaining snaps packages to 0.28 * fix: add patch for snaps-types --------- Co-authored-by: martines3000 <domajnko.martin@gmail.com>
pseudobun
pushed a commit
that referenced
this pull request
Apr 6, 2023
* feat: update types * feat: add createVC RPC method * fix: add bip44CoinTypeNode * test: add params tests * chore: fix tests * feat: add createVC to connector * fix: wrong return type * fix: pr feedback * chore: move queryVCsRequestResult[] type in test * fix: change it.todo in tests * chore: update remaining snaps packages to 0.28 * fix: add patch for snaps-types --------- Co-authored-by: martines3000 <domajnko.martin@gmail.com>
This was referenced Apr 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.