Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New popups #131

Merged
merged 8 commits into from
Mar 20, 2023
Merged

feat: New popups #131

merged 8 commits into from
Mar 20, 2023

Conversation

andyv09
Copy link
Member

@andyv09 andyv09 commented Mar 7, 2023 •
edited
Loading

  • Fixed snapConfirm function
  • Implemented new Snaps UI
  • Added confirmation popup to (query, save, delete, switchMethod, toggleVCStore & togglePopups)
  • Fixed friendlyDapps (When querying VCs Snap will store origin so the popup happens only the first time you queryVCs)
  • Fixed tests

martines3000
martines3000 requested changes Mar 7, 2023
View reviewed changes
Copy link
Member

@martines3000 martines3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes needed. Other than that looks good. 💪

@martines3000 martines3000 merged commit aae6312 into develop Mar 20, 2023
@martines3000 martines3000 deleted the feat/new-popups branch March 20, 2023 13:28
This was referenced Mar 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martines3000 martines3000 martines3000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyv09 @martines3000