-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Balances can now be displayed in the desired currency. #44
Conversation
…s in some files have been made compatible with translations, and incorrect values have been corrected.
… their preferred currency from Settings > General > Currencies. The language file has been updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@egemenkus Hi, some tests are failing:
|
Can you check now please? I solved it and test it |
Signed-off-by: Ruben <rubdeivis@gmail.com>
Thank you for that. I synced with main and updated the package.json version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thanks.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Users could only see their balances in USD.
Issue Number: N/A
What is the new behavior?
Users can choose the currency in which they want to view their balances.
Does this PR introduce a breaking change?
Other information
Visuals of the Changes