Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Ledger integration error #1201

Closed
1 task done
ihorbond opened this issue Aug 8, 2022 · 3 comments
Closed
1 task done

[Bug]: Ledger integration error #1201

ihorbond opened this issue Aug 8, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ihorbond
Copy link
Contributor

ihorbond commented Aug 8, 2022

Current Behavior

After installing "@web3-onboard/ledger": "^2.1.7" and importing get the following error:

ERROR in ./node_modules/@ledgerhq/hw-transport-webusb/lib-es/TransportWebUSB.js
Module not found: Error: Can't resolve '@ledgerhq/devices/hid-framing' in 'C:\Code\zerocodenft\mint\node_modules@ledgerhq\hw-transport-webusb\lib-es'

Expected Behavior

Ledger integration works as intended

Steps To Reproduce

npm i @web3-onboard/ledger
import it somewhere
build & run the app

What package is effected by this issue?

@web3-onboard/ledger

Is this a build or a runtime issue?

Runtime

Package Version

2.5.0

Node Version

16.15

What browsers are you seeing the problem on?

Chrome

Relevant log output

ERROR in ./node_modules/@ledgerhq/hw-transport-webusb/lib-es/TransportWebUSB.js
Module not found: Error: Can't resolve '@ledgerhq/devices/hid-framing' in 'C:\Code\zerocodenft\mint\node_modules\@ledgerhq\hw-transport-webusb\lib-es'

Anything else?

No response

Sanity Check

  • If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.
@ihorbond ihorbond added the bug Something isn't working label Aug 8, 2022
@Adamj1232
Copy link
Member

@ihorbond this looks like an internal Ledger issue that can be found here
We will keep an eye on it and update with any changes around this issue.
Thanks for reporting it!

@ihorbond
Copy link
Contributor Author

ihorbond commented Aug 9, 2022

ah good call, I should have done better research into it. for Nuxt v2 the fix is just adding

alias: {
  "@ledgerhq/devices": "@ledgerhq/devices/lib-es"
}

to the nuxt.config.js

@lnbc1QWFyb24
Copy link
Collaborator

@ihorbond thanks for posting the fix here, i'll close this issue for the moment, but feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants