Skip to content

Fix the Safe connector options and add Blockscout to the list of allowed domains #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 10, 2024

Conversation

maxaleks
Copy link
Contributor

@maxaleks maxaleks commented Jan 5, 2024

Description

  1. Renamed whitelistedDomains option to allowedDomains according to the source code of the Safe Apps SDK: https://github.com/safe-global/safe-apps-sdk/blob/%40safe-global/safe-apps-sdk%408.0.0/packages/safe-apps-sdk/src/sdk.ts#L9
  2. Added Blockscout to the default list of allowed domains

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

@Adamj1232 Adamj1232 merged commit 844616b into thirdweb-dev:develop Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants