Skip to content

Commit

Permalink
feat: change copy of intro modal CTA, fixes #466
Browse files Browse the repository at this point in the history
  • Loading branch information
hstove committed Aug 19, 2020
1 parent faa8071 commit 6b64222
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
source: 'packages/app/vercel.json'
target: 'packages/app/dist/vercel.json'
- name: Deploy Blockstack App with Vercel
- uses: aulneau/vercel-action@v19.0.2+3
uses: aulneau/vercel-action@v19.0.2+3
id: vercel-deployment-blockstack-app
if: github.event_name == 'pull_request'
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:
scope: ${{ secrets.VERCEL_SCOPE }}
working-directory: packages/test-app/dist
- uses: amondnet/vercel-action@v19.0.1+2
id: vercel-deployment-production
id: vercel-deployment-production-ui-docs
if: github.event_name == 'push' || github.event_name == 'release'
name: Deploy UI documentation to production
with:
Expand Down
11 changes: 7 additions & 4 deletions packages/app/tests/integration/page-objects/demo.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ export class DemoPage {
$openAuthButton = createTestSelector('button-skip-connect');
authResponse = '#auth-response';
appPriivateKey = '#app-private-key';
getStarted = '//span[text()="Get Started"]';
getStartedPopUp = 'css=button>span >> text="Get started"';
getStarted = '//span[text()="Get your Secret Key"]';
getStartedPopUp = 'css=button>span >> text="Get your Secret Key"';
skipBtn = 'text="Skip"';
postTextarea = 'div.DraftEditor-root';
postBtn = '//span[text()="Post"]';
profileBtn = '//*[@title="Your Profile"]';
logoutBtn = '//*[contains(text(),"Log out")]';
alreadyHaveSecretKeyLink = '//span[text()="I already have a Secret Key"]';
alreadyHaveSecretKeyLink = '//span[text()="Sign in"]';
openConnectBtn = createTestSelector('sign-up');
openSignInBtn = createTestSelector('sign-in');

Expand Down Expand Up @@ -49,7 +49,10 @@ export class DemoPage {
async waitForAuthResponse() {
await this.page.waitForSelector('#auth-response', { state: 'attached', timeout: 15000 });
const authResponseEl = await this.page.$('#auth-response');
const authResponse = (await this.page.evaluate(el => el?.getAttribute('value'), authResponseEl)) as string;
const authResponse = (await this.page.evaluate(
el => el?.getAttribute('value'),
authResponseEl
)) as string;
return authResponse;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/connect/src/react/components/screens/intro.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export const Intro = () => {
/>
<ScreenActions>
<Button width="100%" size="lg" mt="tight" onClick={() => doAuth()}>
Get started
Get your Secret Key
</Button>
</ScreenActions>
<ScreenFooter>
Expand Down

0 comments on commit 6b64222

Please sign in to comment.