Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16px padding in the header instead of 24px #261

Closed
jasperjansz opened this issue Mar 3, 2020 · 0 comments
Closed

16px padding in the header instead of 24px #261

jasperjansz opened this issue Mar 3, 2020 · 0 comments

Comments

@jasperjansz
Copy link

Currently, the padding for the body and the header of the popup are both 24px.

By having the padding for the header be smaller, 16px, we establish a clearer hierarchy of content. It makes it clear the header is not part of the body and looks better:

image.png

Here's a breakdown:

image.png

Another:

image.png
image.png

I know it's easier to have the same padding all around, but in this case, this change makes our UI clearer and more scannable. The same goes for mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant