Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix functionality of "sendToSignIn" property for "authOptions" as passed to "showBlockstackConnect" function #507

Closed
markmhendrickson opened this issue Jul 12, 2020 · 0 comments · Fixed by #551
Assignees
Labels
bug Functionality broken
Milestone

Comments

@markmhendrickson
Copy link
Collaborator

markmhendrickson commented Jul 12, 2020

Regardless of the value I set for sendToSignIn (true or false) in the authOptions parameter, the introductory modal appears whenever triggering the showBlockstackConnect instead of going straight to the sign in popup.

import { showBlockstackConnect } from '@blockstack/connect';

var sendToSignIn = true;

let authOptions = {
  appDetails: {
    name: 'Humans',
    icon: `${window.location.origin}/favicon.ico`,
  },
  finished: ({ userSession }) => {
    window.location.reload();
  },
  redirectTo: '/',
  sendToSignIn: sendToSignIn ? true : false,
  userSession: userSession
};

showBlockstackConnect(authOptions);

See https://github.com/markmhx/humans/blob/master/app/services/session.js#L10 as triggered by https://github.com/markmhx/humans/blob/master/app/components/app-nav.js#L9

@markmhendrickson markmhendrickson changed the title Fix sendToSignIn property for authOptions given to sendToSignIn function Fix sendToSignIn property for authOptions given to showBlockstackConnect function Jul 12, 2020
@markmhendrickson markmhendrickson changed the title Fix sendToSignIn property for authOptions given to showBlockstackConnect function Fix functionality of "sendToSignIn" property for "authOptions" as passed to "showBlockstackConnect" function Jul 12, 2020
@markmhendrickson markmhendrickson added the bug Functionality broken label Jul 12, 2020
@markmhendrickson markmhendrickson added this to the 2020 W29-W31 milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants