Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a SpliceSpecifier AST class #75

Open
katzdm opened this issue Jul 16, 2024 · 0 comments
Open

Introduce a SpliceSpecifier AST class #75

katzdm opened this issue Jul 16, 2024 · 0 comments
Labels
refactoring Tech debt, yay

Comments

@katzdm
Copy link
Collaborator

katzdm commented Jul 16, 2024

During P2996 wording review in St Louis, the notion of a splice-specifier was introduced for the [: constant-expression :] form shared by splice-expressions, splice-type-specifiers, splice-template-names, and splice-namespace-qualifiers. This is analogous to our internal notion of a CXXIndeterminateSpliceExpr - at minimum we should change the name, but we might also consider replacing it with a non-Expr class in some clang/include/AST/SpliceSpecifier.h (i.e., class SpliceSpecifier).

This might also give some breathing room to change the somewhat ridiculously named CXXExprSpliceExpr to CXXSpliceExpr (since there's then no longer a need to disambiguate from any other CXX*SpliceExpr classes), which would be nice.

@katzdm katzdm added the refactoring Tech debt, yay label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Tech debt, yay
Projects
None yet
Development

No branches or pull requests

1 participant