Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log delete bug that occurs when there's low disk space #4894

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

morgando
Copy link
Contributor

No description provided.

@morgando morgando force-pushed the main_logdel_headroom branch from 7606114 to effa053 Compare December 11, 2024 15:41
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 10/592 tests failed ⚠.

The first 10 failing tests are:
sc_newuniq [setup failure]
basic_rowlocks_generated [setup failure]
sc_transactional_rowlocks_generated
phys_rep_perf
analyze_exit_immediately
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
snap_ha_retry_newsi_generated
dbcreate

@morgando morgando force-pushed the main_logdel_headroom branch from 1c5c0ee to ce722d1 Compare December 13, 2024 19:51
@morgando morgando marked this pull request as ready for review December 13, 2024 21:25
Signed-off-by: Morgan Douglas <mdouglas47@bloomberg.net>
@morgando morgando force-pushed the main_logdel_headroom branch from ce722d1 to b42561f Compare December 16, 2024 15:51
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 134/594 tests failed ⚠.

The first 10 failing tests are:
writes_remsql_names_negativerowid_generated [setup failure]
fdb_compat
phys_rep_perf
analyze_exit_immediately
snapisol_partial_index_off_generated
snapisol_noearly_generated
snapisol
snap_ha_retry_newsi_generated
fdb_compat_rte_connect_generated
ddl_csc2

@morgando morgando merged commit 0fd49be into bloomberg:main Dec 23, 2024
1 check passed
@morgando morgando deleted the main_logdel_headroom branch December 23, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants