Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] topology.kubernetes.io values in metrics #84

Open
mtougeron opened this issue Apr 30, 2020 · 4 comments
Open

[feature request] topology.kubernetes.io values in metrics #84

mtougeron opened this issue Apr 30, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mtougeron
Copy link
Contributor

It would be awesome if the metrics could include the node's topology.kubernetes.io/region & topology.kubernetes.io/zone (not sure what the non-AWS fields are called). That would help quickly identify patterns in the results. e.g., zone "a" is slower than zone "b" or that cross-zone traffic is what's causing a large spike in response times. Not sure if this is possible within the framework of this tool.

keep up the great work & thank you!

@seeker89 seeker89 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 30, 2020
@seeker89
Copy link
Contributor

These annotations seem to be popular.

I think that's a great idea. It would need to (optionally) broaden the privs to also list nodes, and then match its own pod to the node to populate the extra labels. It's a 👍 from me.

Now just someone needs to find a couple of hours to add it :)

@mtougeron
Copy link
Contributor Author

haha the even present "find the time" bug. i hear that. :)

@xlanor
Copy link

xlanor commented Jan 23, 2022

@seeker89 I'd like to work on this as I do have some spare time. As I'm relatively new to the project and code base, which are some of the files I should be taking a look at?

@patsevanton
Copy link

A very necessary feature. Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants