Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create a builtin module for rpm-ostree #24

Closed
gmpinder opened this issue Jan 27, 2024 · 3 comments · Fixed by #68
Closed

feat: Create a builtin module for rpm-ostree #24

gmpinder opened this issue Jan 27, 2024 · 3 comments · Fixed by #68
Assignees

Comments

@gmpinder
Copy link
Member

We should pull in logic for running the rpm-ostree module into the template. This will allow us to take advantage of using cache mounts to help speed up builds as updating the rpmdb is a slow process during builds.

@gmpinder gmpinder self-assigned this Jan 27, 2024
@gmpinder gmpinder added this to the 🚀 V1 Release 🚀 milestone Jan 27, 2024
@xynydev
Copy link
Member

xynydev commented Feb 10, 2024

Do the cache mounts also provide benefits in CI/CD with ephemeral builders?

@gmpinder
Copy link
Member Author

Do the cache mounts also provide benefits in CI/CD with ephemeral builders?

Unfortunately it would only benefit local builds unless a user had their own runner setup for their repo.

@gmpinder gmpinder linked a pull request Feb 17, 2024 that will close this issue
@gmpinder
Copy link
Member Author

Ok so rather than taking over the rpm-ostree module as a whole, the cli is just going to have a cache mount. With how complex the rpm-ostree module could get, I think it would be best to keep it as a script module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants