Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing for install_requirements.sh #836

Closed
OliEfr opened this issue Apr 1, 2021 · 2 comments
Closed

Add testing for install_requirements.sh #836

OliEfr opened this issue Apr 1, 2021 · 2 comments

Comments

@OliEfr
Copy link
Contributor

OliEfr commented Apr 1, 2021

Add testing for install_requirements.sh

I think the easiest test for this script would be to just call it in our build pipeline (a.k.a in our .github workflows) :-)
I do not think that it would make sense to write a unittest for the content of this file (IMHO).

Originally posted by @nils-braun in #833 (comment)
@OliEfr
Copy link
Contributor Author

OliEfr commented Apr 1, 2021

you can assign me

@nils-braun
Copy link
Collaborator

Fixes, as there is no installation script anymore :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nils-braun @OliEfr