Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call depth is inconsistent in Inspector's call and call_end method #1018

Closed
Troublor opened this issue Jan 28, 2024 · 2 comments
Closed

Call depth is inconsistent in Inspector's call and call_end method #1018

Troublor opened this issue Jan 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Troublor
Copy link

I am looking at the main branch commit b434308.
The call depth (context.journaled_state.depth()) is different for the inspector's hook call and call_end regarding the same call.

For instance, suppose there is a contract-invoking transaction which does not contain any subcalls. The call and call_end hook of inspector will only be called each once for the top-level call.
When call hook is called, the context.journaled_state.depth() is 0, which is expected.
However, when call_end hook is called, the context.journaled_state.depth() is 1. This behavior is different from previous versions of revm. In revm v3.5.0, the context.journaled_state.depth() in call_end is also 0.
This behavior difference is likely a regression issue introduced in the recent redesign of the evm after v3.5.0.

Is this change of behavior intended?

@rakita rakita added the bug Something isn't working label Jan 28, 2024
@rakita
Copy link
Member

rakita commented Jan 30, 2024

Behaviour should have stayed the same, it is fixed in #1024

Thanks for reporting!

@rakita
Copy link
Member

rakita commented Jan 30, 2024

tested here: #1028

@rakita rakita closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants