We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This panic
revm/crates/revm/src/handler/mainnet/post_execution.rs
Lines 107 to 111 in 13ce013
can be hit with an inspector that returns Some({Call,Create}Output { result: InstructionResult::{Continue,CallOrCreate}, .. }) in call or create.
Some({Call,Create}Output { result: InstructionResult::{Continue,CallOrCreate}, .. })
call
create
Encountered while migrating Foundry in https://github.com/foundry-rs/foundry/pull/7125/files#diff-29a0def5856966de3e16a20140415c388f71da82a37e2cfa0308c0f76085ab9fL659-R660
I'm guessing this is fine as a panic because it can only be hit with an invalid implementation or inspector.
Perhaps a better panic message can be emitted?
The text was updated successfully, but these errors were encountered:
Agreed with said, we should include return flag inside panic.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
This panic
revm/crates/revm/src/handler/mainnet/post_execution.rs
Lines 107 to 111 in 13ce013
can be hit with an inspector that returns
Some({Call,Create}Output { result: InstructionResult::{Continue,CallOrCreate}, .. })
incall
orcreate
.Encountered while migrating Foundry in https://github.com/foundry-rs/foundry/pull/7125/files#diff-29a0def5856966de3e16a20140415c388f71da82a37e2cfa0308c0f76085ab9fL659-R660
I'm guessing this is fine as a panic because it can only be hit with an invalid implementation or inspector.
Perhaps a better panic message can be emitted?
The text was updated successfully, but these errors were encountered: