Return Error if CKZG or BLS features are disabled, but are called.

[DaniPopes]

The precompile address should be specified regardless, but with an implementation that panics at run time so that certain bugs are caught early.

[rupam-04]

Hi, willing to work on this. Can you share some pointers please?

[DaniPopes]

Sure, in revm-precompile lib.rs, instead of conditionally adding precompiles with cfg, they should always be added but with a fallback implementation that panics at runtime.

For example in cancun

revm/crates/precompile/src/lib.rs

Lines 140 to 158 in 30c6362

	pub fn cancun() -> &'static Self {
	static INSTANCE: OnceBox<Precompiles> = OnceBox::new();
	INSTANCE.get_or_init(|| {
	let precompiles = Self::berlin().clone();
	// Don't include KZG point evaluation precompile in no_std builds.
	#[cfg(feature = "c-kzg")]
	let precompiles = {
	let mut precompiles = precompiles;
	precompiles.extend([
	// EIP-4844: Shard Blob Transactions
	kzg_point_evaluation::POINT_EVALUATION,
	]);
	precompiles
	};
	Box::new(precompiles)
	})
	}

the extend should always be enabled, and kzg_point_evaluation::POINT_EVALUATION should be cfg'd internally, with a panic if the feature is not enabled

[rakita]

Would not panic on those. Seems like bad behaviour

[rakita]

Renamed the issue, we should return the error on this.

[rakita]

We should modify PrecompileResult to contain additional field that would return panic like error. https://github.com/bluealloy/revm/blob/30c6362bd4676911fa8f3306b4d8311cee340931/crates/primitives/src/precompile.rs#L9C29-L9C67

Would add something like:

enum PrecompileResult {
    Ok {
      gas_used: u64,
      output: Bytes,
    },
    Error {
        error_type: PrecompileError,
    },
    FatalError {
        msg: String,
    }
}

Fatal error would stop execution, while Ok and Error would work as previously with Result<>.

[rakita]

ref: #1283

[rakita]

Implemented for kzg here: #1589
blst pending and require some code refactoring