Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of storage reverts is 100gb bigger #590

Closed
rakita opened this issue Aug 8, 2023 · 3 comments
Closed

Size of storage reverts is 100gb bigger #590

rakita opened this issue Aug 8, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@rakita
Copy link
Member

rakita commented Aug 8, 2023

New revm state got merged with some known bugs.

This bug is related to storage changeset/reverts, current best assumption is that we dont check storage present/new value when creating the changeset inside bundle state.

@rakita rakita added the bug Something isn't working label Aug 8, 2023
@rakita
Copy link
Member Author

rakita commented Sep 7, 2023

One assumption so I dont forget, when we update the bundle storage with transition storage we should check if those are the same, if they are, remove them.

Hm, we are already doing filtering transition storage as they have both previous and present values.

@rakita
Copy link
Member Author

rakita commented Sep 8, 2023

Okay, this became a funny issue.

Compare the number of StorageChangeSets and the size of it. revm state generates fewer entries but it is +100gb more in size inside reth.

Screenshot 2023-09-08 at 23 25 53 Screenshot 2023-09-08 at 23 26 38

So a difference is that we delete the plain state while inserting it into changesets, while previously we just read it and deleted it afterwards.

@rakita
Copy link
Member Author

rakita commented Sep 9, 2023

Closing this as it is not revm issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant