feat: webhook channel query param #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks ok so far. Perhaps you could use mux routing capabilities to register the route for both, path and query, so the code inside the handler has no special handling. It will just use the mux.Vars map. https://github.com/gorilla/mux?tab=readme-ov-file#registered-urls Another things that would be nice is giving some deprecation notice. Not sure where this could be. Probably in the logs and or as response to the webhook event. In that case we probably do need some special handling to know wether or not to emit the notice. |
Archisman-Mridha
force-pushed
the
fix/39
branch
from
e4b5965
to
7c3ea8a
Compare
Archisman-Mridha
force-pushed
the
fix/39
branch
from
7c3ea8a
to
ed899ce
Compare
Signed-off-by: Nico Braun <rainbowstack@gmail.com>
Signed-off-by: Nico Braun <rainbowstack@gmail.com>
bluebrown
changed the title
/events or /events/<channel-name> endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
Events can now be received at both
/eventsor/events/<channel-name>endpoints