fix(filter): false positive change reports due to context #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nico <rainbowstack@gmail.com>
bluebrown
force-pushed
the
fix/parts-changeslice
branch
from
7709ef0
to
932f158
Compare
|
@rossigee, could you take a look here, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kobold might emit false positives in the changes slice, when using context in combination with no matching tag.
The issue should not impact users in a meaningful way. If there are real changes, there might be a bogus item in the commit message. If there are no changes at all, kobold should fail for that task to commit.
However, this PR fixes the false positives.