Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pkguri)!: Parse ref and pkg as query params #62

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

tsmalls93
Copy link
Contributor

Fixes #45

git/pkguri.go Outdated
@@ -26,32 +26,31 @@ func (uri *PackageURI) String() string {
return fmt.Sprintf("%s.git@%s%s", uri.Repo, uri.Ref, uri.Pkg)
Copy link
Owner

@bluebrown bluebrown Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the string representation needs to change as well.

make e2e
docker tag $(docker pull busybox) localhost:8080/library/busybox:v1.2.3
docker push localhost:8080/library/busybox:v1.2.3
k logs deploy/kobold

{"time":"2024-08-15T09:54:26.240809363Z","level":"INFO","msg":"db config purge","reason":"config file(s) provided"}
{"time":"2024-08-15T09:54:26.259544095Z","level":"INFO","msg":"scheduler started","debounce":15000000000}
{"time":"2024-08-15T09:54:26.259598938Z","level":"INFO","msg":"server startup","name":"webhook","addr":":8080"}
{"time":"2024-08-15T09:54:26.259806752Z","level":"INFO","msg":"server startup","name":"api","addr":":9090"}
{"time":"2024-08-15T09:55:11.502382922Z","level":"INFO","msg":"task queued","channel":"distribution","dec":false,"error":null}
{"time":"2024-08-15T09:55:26.507263767Z","level":"INFO","msg":"scheduler shutdown completed","status":"failure","error":"s.pool.Dispatch(): sql: Scan error on column index 1, name \"repo_uri\": invalid git package uri: \"http://gitea/dev/test.git@mainprod\", query params are missing"}
{"time":"2024-08-15T09:55:26.507362121Z","level":"INFO","msg":"server shutdown","name":"webhook"}
{"time":"2024-08-15T09:55:26.507391381Z","level":"INFO","msg":"server shutdown","name":"api"}
s.pool.Dispatch(): sql: Scan error on column index 1, name "repo_uri": invalid git package uri: "http://gitea/dev/test.git@mainprod", query params are missing

@bluebrown bluebrown merged commit e6ad83e into bluebrown:main Aug 21, 2024
1 check passed
@tsmalls93 tsmalls93 deleted the tyler-url-parsing branch August 21, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package uri doesnt handle branches names properly
2 participants