Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playing different local files crashes iOS #23

Closed
tantzygames opened this issue Jul 13, 2018 · 8 comments
Closed

Playing different local files crashes iOS #23

tantzygames opened this issue Jul 13, 2018 · 8 comments

Comments

@tantzygames
Copy link

Playing multiple files works on Android, but playing a second file crashes iOS with no warning.

Playing the same file multiple times works on iOS. I've just tested with "audioplayer" and it works with different files on iOS, but I would like to use your volume feature.

@luanpotter
Copy link
Member

I believe this was fixed by @feroult on the current release (0.7.0), could you please verify? Thanks!

@tantzygames
Copy link
Author

tantzygames commented Jul 16, 2018

Thanks. I didn't notice the update.

After updating to 0.7.0 and updating my code accordingly, no crashes, but no audio either. My local audio files are now not playing at all.

I tested your example, and:

  • Remote: Pressing the play button the audio does not play. Pressing pause or stop and then play again plays the file.
  • Local File: after I download the file and press the play button the audio does not play. Pressing pause or stop and then play again plays the file.
  • Local Assets: none of the buttons play any audio.
  • Advanced: seems to be working

I only get:
ios -> updateDuration...3.813878
ios -> invokechannel

@erickzanardo
Copy link
Member

@feroult just tested the above and is indeed not working, any thoughts?

@feroult
Copy link
Contributor

feroult commented Jul 17, 2018

I've got a fix: 3c300be

The strange thing is that it wasn't supposed to work before.

Tested all example tabs, it is working well. Would someone please confirm it?

@tantzygames
Copy link
Author

tantzygames commented Jul 17, 2018

Thanks @feroult, you're a champion!

I haven't tested the audioPlayers example, but that fix is working a treat in my project.

@tantzygames
Copy link
Author

Ah, @feroult I spoke too soon. Playing different audio files works the first time each file is played. Subsequent attempts do not play.

Checking the example with 3c300be reveals same behavior. First play works, but subsequent plays don't work without changing tabs (rebuilding the widget?)

@feroult
Copy link
Contributor

feroult commented Jul 19, 2018

@Kretin1

I've got it. The callback wasn't firing the second time because the asset was already loaded: 94430f1

Please let us know if it is not working again in some scenario that you have.

@tantzygames
Copy link
Author

@feroult Thank you so much.

I tested my project and the example, and both appear to be working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants