Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting spec.upgradable on in-use kdapps #592

Closed
joel-bluedata opened this issue Apr 19, 2022 · 0 comments
Closed

allow setting spec.upgradable on in-use kdapps #592

joel-bluedata opened this issue Apr 19, 2022 · 0 comments

Comments

@joel-bluedata
Copy link
Member

Part of issue #588. Depends on issue #589, which should be closed before these changes here are added.

This is mostly so that existing kdclusters for "old" kdapps can be marked to take advantage of live app upgrade IF it is deemed that the old kdapp doesn't need to respond to any upgrade notifications.

We can change KubeDirectorAppSpec.Upgradable to a pointer type, so we can tell when it is unspecified. (And code that looks at this field should treat unspecified as false.) The kdapp change validator can allow setting this field, even for in-use kdapps, if it is currently unspecified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants