Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit/cleanup for upgrade status management #595

Closed
joel-bluedata opened this issue Apr 19, 2022 · 0 comments
Closed

audit/cleanup for upgrade status management #595

joel-bluedata opened this issue Apr 19, 2022 · 0 comments

Comments

@joel-bluedata
Copy link
Member

Part of issue #588.

The status management is spread out quite a bit, although I do recognize that there are places where it's easier to determine that a status change is needed.

As the branch stands:

  • top-level cluster handler manages status.app and status.upgradeInfo
  • statefulset reconciliation manages setting per-role status to upgrading/rollingback
  • creating-member handler manages setting per-member status to upgrading/rollback
  • creating-member handler also manages setting per-role and per-member status to upgraded/rolledback

There's a logic in that structure, but I think we should at least consider whether we can push the role status management into syncClusterRoles, since having status management in the executor package is the only part which really itches me.

I'm also still dubious about the need to have upgradingMembers status at the role-status level, and we don't seem to be making use of the image value stored in that map... but I'll suspend further worrying about that until we're sure that issue #594 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants