Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jackson-core? #154

Open
jeffdcamp opened this issue Apr 19, 2016 · 2 comments
Open

Update jackson-core? #154

jeffdcamp opened this issue Apr 19, 2016 · 2 comments

Comments

@jeffdcamp
Copy link

LoganSquare depends on jackson-core 2.5.1 (from Feb 2015).... is there any reason to move to not move to the latest version? Would/Could there be performance improvements? Are there reasons to staying with the older version?
@mannodermaus
Copy link
Contributor

From my quick tests, LoganSquare works with version 2.7.3 without any issues. I haven't checked the benchmarks yet, however the only reason to hold back on updating that dependency would be the somewhat higher method count and tiny increase in dex size:

Methods count Dependencies JAR Size (KB) DEX size (KB)
jackson-core:2.5.1 1937 0 230 256
jackson-core:2.7.3 2174 0 253 287

@Macarse
Copy link

Macarse commented Sep 8, 2016

@aurae what about performance? is it faster with 2.7.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Macarse @jeffdcamp @mannodermaus